Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1922] Fixes Found Test Packages Output #1535

Merged
merged 5 commits into from
Jan 13, 2025
Merged

[TT-1922] Fixes Found Test Packages Output #1535

merged 5 commits into from
Jan 13, 2025

Conversation

kalverra
Copy link
Collaborator

@kalverra kalverra commented Jan 7, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve the output formatting for a list of packages and introduce a standard library for better output handling in non-JSON scenarios.

What

  • tools/flakeguard/cmd/find.go
    • Imported fmt package for enhanced output formatting.
    • Modified outputResults function to use fmt.Print instead of log.Debug for listing packages when not in JSON mode, appending a space after each package name for better readability.

Copy link
Contributor

@lukaszcl lukaszcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalverra lgtm. Btw, have you executed any (manual) tests to verify it works?

@cl-sonarqube-production
Copy link

@kalverra kalverra merged commit 9658154 into main Jan 13, 2025
52 checks passed
@kalverra kalverra deleted the flakeguardPRFix branch January 13, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants